registry: remove protocol from insecure-registries config #17746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Using a protocol here is meaningless, and is ignored by the daemon (and will even produce a warning in the logs). Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
remove-protocol-from-insecure-registries
branch
from
c2ee3ac to
f4eccb3
Compare
|
@thaJeztah done 🎉 |
ChrisChinchilla
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
@thaJeztah If you're OK with everything this looks fine to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a protocol here is meaningless, and is ignored by the daemon (and will even produce a warning in the logs).
Code reference for the curious: https://github.com/moby/moby/blob/75d7e053dc9496a0b6d653c25f470453f230753b/registry/config.go#L199-L207
Proposed changes
Related issues (optional)